Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for building ARM binaries and containers for Linux … #1876

Closed
wants to merge 32 commits into from
Closed

feat: Add support for building ARM binaries and containers for Linux … #1876

wants to merge 32 commits into from

Conversation

mattheworris
Copy link
Collaborator

@mattheworris mattheworris commented Feb 13, 2024 •
edited
Loading

Goal

Closes #779

Discussion

Changes

How to Test

Checklist

  • Chain spec updated
  • Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • Design doc(s) updated
  • Tests added
  • Benchmarks added
  • Weights updated

@mattheworris mattheworris self-assigned this Feb 13, 2024
@mattheworris mattheworris linked an issue Feb 13, 2024 that may be closed by this pull request
Build ARM binaries and containers for Linux and MacOS #779
Open
10 tasks
@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch 9 times, most recently from 142e92b to 03bb6e6 Compare February 14, 2024 18:38
@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch from 03bb6e6 to 08041ec Compare February 14, 2024 18:41
@mattheworris
Copy link
Collaborator Author

Currently tabled, as it does not appear that Docker is currently working on macOs runners.

@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch 2 times, most recently from ba0441b to 3577f2e Compare March 7, 2024 00:08
@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch from 3577f2e to c35342a Compare March 7, 2024 00:15
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (b871aac) to head (35ec22c).

❗ Current head 35ec22c differs from pull request most recent head 27e2bc2. Consider uploading reports for the commit 27e2bc2 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1876   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          56       56           
  Lines        4525     4525           
=======================================
  Hits         3761     3761           
  Misses        764      764

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch 2 times, most recently from 5a1c300 to 35ec22c Compare March 8, 2024 17:10
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 8, 2024
@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch from 35ec22c to d0d46f7 Compare March 8, 2024 22:56
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 8, 2024
@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch from 4ab4738 to aa8a15c Compare March 11, 2024 14:31
Matthew Orris and others added 22 commits March 11, 2024 08:50
Add wasm32-unknown-unknown target and support for Linux-aarch64 platform
630155e
Add wasm32-unknown-unknown target for specified toolchain
3220f04
Update package installation for Linux and macOS
c91aca5
Update build scripts to set PROTOC environment variable
8f8f9aa
@mattheworris
Merge branch 'main' into 779-build-arm-binaries-and-containers-for-li…
44f055f 
…nux-and-macos
Update build scripts to install protobuf compiler
ad213f1
Update target for Linux-aarch64 platform and add protoc version check
94c6d5b
Update runs-on value in verify-pr-commit.yml workflow
2f8a757
Add container configuration for CI workflow
2a48b99
Commented out unnecessary package installation for Linux
2293f93
Update cross-compilation script
a48470b
fix: update action.yml to use correct version of rust-cross
ff4d380
Update Rust cross-compilation workflow
003be7c
Update determine-cross-version.sh path in rust-cross workflow
13e80e5
Add CROSS_CONTAINER_IN_CONTAINER environment variable to the CI workflow
8f3d969
Add CROSS_REMOTE environment variable
299aee5
Remove CROSS_REMOTE environment variable
4bf286c
Add pre-build commands to Cross.toml
06de4ef
Update Cross.toml to include pre-build commands for aarch64-unknown-l…
59a38c1 
…inux-gnu target
Update Cross.toml and add aarch64-unknown-linux-gnu.dockerfile
388cc69
Update Dockerfile path in Cross.toml
1830b76
Update base image to latest version
27e2bc2
@mattheworris mattheworris force-pushed the 779-build-arm-binaries-and-containers-for-linux-and-macos branch from c35a1d6 to 27e2bc2 Compare March 13, 2024 14:18
@wilwade
Copy link
Collaborator

wilwade commented Oct 29, 2024

Closing for now

@wilwade wilwade closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demisx demisx Awaiting requested review from demisx demisx will be requested when the pull request is marked ready for review demisx is a code owner

@wilwade wilwade Awaiting requested review from wilwade wilwade will be requested when the pull request is marked ready for review wilwade is a code owner

Assignees

@mattheworris mattheworris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build ARM binaries and containers for Linux and MacOS
2 participants
@mattheworris @wilwade