time-release mock and unit tests should match runtime configuration
#1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattheworris
commented
Jan 30, 2024
| @@ -16,8 +16,8 @@ pub type Schedule<T> = ReleaseSchedule<BlockNumberFor<T>, BalanceOf<T>>; | |||
| const SEED: u32 = 0; | |||
|
|
|||
| fn set_balance<T: Config>(who: &T::AccountId, balance: BalanceOf<T>) { | |||
| let actual_deposit = T::Currency::mint_into(&who, balance.saturated_into()); | |||
| assert_eq!(balance, actual_deposit.unwrap()); | |||
| let actual_deposit = T::Currency::set_balance(&who, balance.saturated_into()); | |||
There was a problem hiding this comment.
mint_into fails when the account has a 0 balance.
set_balance is infallible and provided by polkadot-sdk specifically for benchmarking and testing.
mattheworris
commented
Jan 30, 2024
| @@ -15,9 +15,12 @@ | |||
| ], | |||
| // Set the features to use for cargo commands | |||
| "rust-analyzer.cargo.features": [ | |||
| "frequency-no-relay" | |||
| "frequency-no-relay", | |||
| "runtime-benchmarks", | |||
There was a problem hiding this comment.
Adding these targets to cover more code, e.g. benchmarking.rs files do not know about any definitions if runtime-benchmarks is not defined.
2672522 to
a08ed4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1861 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 56 56
Lines 4552 4552
=======================================
Hits 3776 3776
Misses 776 776 ☔ View full report in Codecov by Sentry. |
time-release mock and unit tests should match runtime configuration
…1836-time-release-pallet-mock-and-unit-test-need-updates
…1836-time-release-pallet-mock-and-unit-test-need-updates
added 3 commits
February 2, 2024 09:27
…s' of https://github.com/LibertyDSNP/frequency into 1836-time-release-pallet-mock-and-unit-test-need-updates
3eb3dca to
3a12faa
Compare
JoeCap08055
approved these changes
Feb 2, 2024
aramikm
approved these changes
Feb 5, 2024
saraswatpuneet
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to update the
time-releasemock so the theMinReleaseTransfermatches the value in the runtime configuration.This may cause follow on failures in some of the unit tests.
Closes #1836
Changes
MinReleaseTransferupdated to 0.vscode/settings.jsonupdated to include more targets for better feature coverageHow to Test
time-releaseunit tests passChecklist