feat: add VERSION to ci-base-image #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
added 6 commits
October 23, 2023 15:23
mattheworris
commented
Oct 24, 2023
wilwade
approved these changes
Oct 24, 2023
demisx
reviewed
Oct 24, 2023
demisx
requested changes
Oct 24, 2023
feffb49 to
1ac5b4b
Compare
enddynayn
reviewed
Oct 24, 2023
| @@ -81,6 +81,7 @@ jobs: | |||
| name: Publish CI Base Image | |||
| env: | |||
| IMAGE_NAME: ci-base-image | |||
| IMAGE_VERSION: 1.0.0 | |||
wilwade
pushed a commit
that referenced
this pull request
Oct 25, 2023
# Goal The goal of this PR is to publish the 1.0.0 version of ci-base-image. # Discussion Due to a typo in `merge-pr.yml`, #1735 failed to publish a new version of `ci-base-image`. This PR touches `ci-base-image.dockerfile` to trigger the `publish-ci-base-image` github action workflow. Co-authored-by: Matthew Orris <--help>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to add a version to the
ci-base-imagecontainer when it is published to DockerHub.IMAGE_VERSIONis added to the publishing jobs and stored as aLABELin the container itself.IMAGE_VERSIONwill be baselined as1.0.0docker inspectcan be used to check the version of a container and should be in-sync with the tag version.A follow on PR will be used to update the github workflows to use the version number.
Discussion
The current workflows pull using the defaults, which is the
latesttag.Adding a version will allows us better traceability and better maintenance moving forward.