chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 #1730

enddynayn · 2023-10-20T23:44:18Z

The goal of this PR is to upgrade from v1.0.0 to v1.1.0.

Benchmarks updated for custom pallets and overhead.

References

Closes Issue #1687

codecov · 2023-10-25T23:38:22Z

Codecov Report

Merging #1730 (8c027b7) into main (dbdeb5c) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
+ Coverage   87.95%   88.07%   +0.11%     
==========================================
  Files          50       50              
  Lines        4243     4243              
==========================================
+ Hits         3732     3737       +5     
+ Misses        511      506       -5

Files	Coverage Δ
common/primitives/src/msa.rs	`91.56% <ø> (ø)`
common/primitives/src/rpc.rs	`93.02% <ø> (ø)`
common/primitives/src/schema.rs	`73.91% <ø> (+1.57%)`	⬆️
pallets/capacity/src/types.rs	`94.69% <ø> (-0.85%)`	⬇️
pallets/frequency-tx-payment/src/lib.rs	`85.09% <ø> (+0.48%)`	⬆️
pallets/handles/src/handles_signed_extension.rs	`56.52% <ø> (ø)`
pallets/handles/src/lib.rs	`92.41% <ø> (ø)`
pallets/msa/src/lib.rs	`90.00% <ø> (ø)`
pallets/schemas/src/lib.rs	`87.32% <ø> (+0.70%)`	⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

runtime/frequency/src/lib.rs

github-actions · 2023-10-26T21:20:26Z

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

github-actions · 2023-10-26T21:26:21Z

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

github-actions · 2023-10-30T15:13:40Z

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

github-actions · 2023-10-30T15:41:29Z

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 7164ae0.

github-actions · 2023-10-30T22:17:32Z

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

github-actions · 2023-10-30T22:47:26Z

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 5e2fd02.

The goal of this PR is to upgrade from v1.0.0 to v1.1.0. Update benchmarks for custom pallets and overhead. References - [Polkadot Forum](https://forum.polkadot.network/t/polkadot-release-analysis-v1-1-0/3988) - [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.1.0) Co-authored-by: Enddy Dumbrique <enddy.dumbrique@unfinished.com> Co-authored-by: Matthew Orris <1466844+mattheworris@users.noreply.github.com>

enddynayn · 2023-10-30T23:21:17Z

pallets/msa/src/weights.rs

@@ -96,17 +96,18 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 	/// Storage: `Msa::DelegatorAndProviderToDelegation` (r:1 w:1)
 	/// Proof: `Msa::DelegatorAndProviderToDelegation` (`max_values`: None, `max_size`: Some(217), added: 2692, mode: `MaxEncodedLen`)
 	/// Storage: `Schemas::CurrentSchemaIdentifierMaximum` (r:1 w:0)
-	/// Proof: `Schemas::CurrentSchemaIdentifierMaximum` (`max_values`: Some(1), `max_size`: None, mode: `Measured`)
+	/// Proof: `Schemas::CurrentSchemaIdentifierMaximum` (`max_values`: Some(1), `max_size`: Some(2), added: 497, mode: `MaxEncodedLen`)


how did we get MaxEncodedLen here?

My guess is that Parity might've fixed some issues in benchmarking. So previously sometimes when we were accessing other pallets it would count them as measured even though the top level benchmark had MaxEncodedLen and it looks like that issue might've fixed

wilwade

Looks good to me.

Might be worth cleaning up the cargo deny warnings, but not a blocker.

Ran various local tests
Ran several versions

aramikm

Overall looks good a couple of questions and concerns

Since try-runtime is separated into a different binary I think our try-runtime script would fail but it was failing before so not a blocker
concern: Are we sure if there is no internal storage migrations for the frame-pallets that we use?

node/service/src/service.rs

pallets/messages/src/weights.rs

aramikm · 2023-10-31T18:58:21Z

pallets/msa/src/weights.rs

@@ -96,17 +96,18 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 	/// Storage: `Msa::DelegatorAndProviderToDelegation` (r:1 w:1)
 	/// Proof: `Msa::DelegatorAndProviderToDelegation` (`max_values`: None, `max_size`: Some(217), added: 2692, mode: `MaxEncodedLen`)
 	/// Storage: `Schemas::CurrentSchemaIdentifierMaximum` (r:1 w:0)
-	/// Proof: `Schemas::CurrentSchemaIdentifierMaximum` (`max_values`: Some(1), `max_size`: None, mode: `Measured`)
+	/// Proof: `Schemas::CurrentSchemaIdentifierMaximum` (`max_values`: Some(1), `max_size`: Some(2), added: 497, mode: `MaxEncodedLen`)


My guess is that Parity might've fixed some issues in benchmarking. So previously sometimes when we were accessing other pallets it would count them as measured even though the top level benchmark had MaxEncodedLen and it looks like that issue might've fixed

pallets/stateful-storage/src/weights.rs

runtime/common/Cargo.toml

runtime/frequency/src/lib.rs

enddynayn · 2023-10-31T20:31:49Z

Overall looks good a couple of questions and concerns

Since try-runtime is separated into a different binary I think our try-runtime script would fail but it was failing before so not a blocker

concern: Are we sure if there is no internal storage migrations for the frame-pallets that we use?

I did not see any migrations but perhaps I missed one @mattheworris?

mattheworris · 2023-10-31T20:40:37Z

Overall looks good a couple of questions and concerns

Since try-runtime is separated into a different binary I think our try-runtime script would fail but it was failing before so not a blocker

concern: Are we sure if there is no internal storage migrations for the frame-pallets that we use?

I did not see any migrations but perhaps I missed one @mattheworris?

There are no migrations called out in the release notes for v1.1.0.

aramikm

Great Job! Good to go!

saraswatpuneet

I have reviewed the changes and looks good, however wont be able to approve since I havent run full tests

Otherwise good to go

enddynayn · 2023-10-31T20:56:06Z

I have reviewed the changes and looks good, however wont be able to approve since I havent run full tests

Otherwise good to go

Please take the time to run the full test that you need to give it your approval.

shannonwells · 2023-10-31T20:57:01Z

runtime/common/src/weights/extrinsic_weights.rs

+	///   Min, Max: 100_113, 110_777
+	///   Average:  101_295
+	///   Median:   101_040
+	///   Std-Dev:  1335.33


Just noting that this is a jump of ~30% in std-dev which means the weight calculations are varying more widely in this benchmark run.

shannonwells

Good work, ship it!

enddynayn changed the title ~~Chore/upgrade v1.0.0 to polkadot v1.1.0 ssue 1687~~ Chore/upgrade v1.0.0 to polkadot v1.1.0 Oct 20, 2023

enddynayn changed the title ~~Chore/upgrade v1.0.0 to polkadot v1.1.0~~ chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 Oct 20, 2023

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch 3 times, most recently from dbb4e03 to 5945ad6 Compare October 25, 2023 23:23

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch 2 times, most recently from 106ce11 to 3d358db Compare October 26, 2023 18:56

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 26, 2023

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch from 10792d4 to 4afd537 Compare October 26, 2023 20:31

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Oct 26, 2023

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch 2 times, most recently from 5d22eeb to 1a60415 Compare October 26, 2023 20:54

enddynayn commented Oct 26, 2023

View reviewed changes

runtime/frequency/src/lib.rs Show resolved Hide resolved

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch 2 times, most recently from b63d691 to 3fbc3d5 Compare October 26, 2023 21:12

enddynayn marked this pull request as ready for review October 26, 2023 21:12

enddynayn requested a review from wilwade as a code owner October 26, 2023 21:12

mattheworris self-assigned this Oct 26, 2023

mattheworris assigned enddynayn Oct 26, 2023

mattheworris requested a review from a team October 26, 2023 21:27

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Oct 26, 2023

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch from eb316eb to 668b348 Compare October 26, 2023 23:12

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Oct 27, 2023

demisx pushed a commit that referenced this pull request Oct 30, 2023

Update weights for PR #1730

7164ae0

mattheworris added benchmark Extrensic benchmark needed change/major Major Changes in this PR labels Oct 30, 2023

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Oct 30, 2023

demisx pushed a commit that referenced this pull request Oct 30, 2023

Update weights for PR #1730

5e2fd02

enddynayn force-pushed the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch from 5e2fd02 to 8c027b7 Compare October 30, 2023 23:11

enddynayn commented Oct 30, 2023

View reviewed changes

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 31, 2023

wilwade approved these changes Oct 31, 2023

View reviewed changes

aramikm reviewed Oct 31, 2023

View reviewed changes

aramikm approved these changes Oct 31, 2023

View reviewed changes

saraswatpuneet reviewed Oct 31, 2023

View reviewed changes

shannonwells reviewed Oct 31, 2023

View reviewed changes

shannonwells approved these changes Oct 31, 2023

View reviewed changes

JoeCap08055 approved these changes Nov 1, 2023

View reviewed changes

mattheworris merged commit c604f7d into main Nov 1, 2023
30 checks passed

mattheworris deleted the chore/upgrade-v1.0.0-to-polkadot-v1.1.0-ssue-1687 branch November 1, 2023 15:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 #1730

chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 #1730

enddynayn commented Oct 20, 2023 •

edited by mattheworris

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

enddynayn Oct 30, 2023

aramikm Oct 31, 2023

wilwade left a comment

aramikm left a comment •

edited

Loading

aramikm Oct 31, 2023

enddynayn commented Oct 31, 2023

mattheworris commented Oct 31, 2023

aramikm left a comment

saraswatpuneet left a comment

enddynayn commented Oct 31, 2023

shannonwells Oct 31, 2023

shannonwells left a comment

chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 #1730

chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 #1730

Conversation

enddynayn commented Oct 20, 2023 • edited by mattheworris Loading

codecov bot commented Oct 25, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

enddynayn Oct 30, 2023

Choose a reason for hiding this comment

aramikm Oct 31, 2023

Choose a reason for hiding this comment

wilwade left a comment

Choose a reason for hiding this comment

aramikm left a comment • edited Loading

Choose a reason for hiding this comment

aramikm Oct 31, 2023

Choose a reason for hiding this comment

enddynayn commented Oct 31, 2023

mattheworris commented Oct 31, 2023

aramikm left a comment

Choose a reason for hiding this comment

saraswatpuneet left a comment

Choose a reason for hiding this comment

enddynayn commented Oct 31, 2023

shannonwells Oct 31, 2023

Choose a reason for hiding this comment

shannonwells left a comment

Choose a reason for hiding this comment

enddynayn commented Oct 20, 2023 •

edited by mattheworris

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading

aramikm left a comment •

edited

Loading