Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: added create_schema_v2 #1725

Merged
merged 6 commits into from
Oct 24, 2023
Merged

schemas: added create_schema_v2 #1725

merged 6 commits into from
Oct 24, 2023

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Oct 19, 2023

Goal

The goal of this PR is to add a new extrinsic to be able to create schemas with settings, without the need for governance in local and test-net environments.

Closes #1715

Checklist

  • Chain spec updated
  • Tests added
  • Benchmarks added
  • Weights updated

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1725 (42f390b) into main (831337e) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
+ Coverage   87.88%   87.95%   +0.07%     
==========================================
  Files          50       50              
  Lines        4241     4243       +2     
==========================================
+ Hits         3727     3732       +5     
+ Misses        514      511       -3     
Files Coverage Δ
pallets/messages/src/lib.rs 90.00% <100.00%> (+0.59%) ⬆️
pallets/messages/src/types.rs 75.67% <100.00%> (+1.99%) ⬆️
pallets/schemas/src/lib.rs 86.61% <100.00%> (+1.11%) ⬆️
pallets/schemas/src/types.rs 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aramikm aramikm self-assigned this Oct 23, 2023
@aramikm aramikm changed the title [WIP] schemas: added create_schema_v2 schemas: added create_schema_v2 Oct 23, 2023
@github-actions
Copy link

Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions
Copy link

Finished running benchmarks. Updated weights have been committed to this PR branch in commit 42f390b.

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 23, 2023
@aramikm aramikm marked this pull request as ready for review October 24, 2023 00:41
@aramikm aramikm requested a review from wilwade as a code owner October 24, 2023 00:41
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

  • Reviewed code
  • Verified mainnet filter

Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- though do we maybe want to call it create_schema_with_settings?

@wilwade
Copy link
Collaborator

wilwade commented Oct 24, 2023

lgtm -- though do we maybe want to call it create_schema_with_settings?

I'm good with just the v2 myself, but don't feel strongly about it.

@aramikm aramikm merged commit 38a5087 into main Oct 24, 2023
30 checks passed
@aramikm aramikm deleted the create_schema_v2 branch October 24, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_schema Needs a v2 that supports Schema settings
5 participants