-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemas: added create_schema_v2 #1725
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
+ Coverage 87.88% 87.95% +0.07%
==========================================
Files 50 50
Lines 4241 4243 +2
==========================================
+ Hits 3727 3732 +5
+ Misses 514 511 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 42f390b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
- Reviewed code
- Verified mainnet filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm -- though do we maybe want to call it create_schema_with_settings
?
I'm good with just the v2 myself, but don't feel strongly about it. |
Goal
The goal of this PR is to add a new extrinsic to be able to create schemas with settings, without the need for governance in
local
andtest-net
environments.Closes #1715
Checklist