-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed without_storage_info from messages and schema pallets #1702
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1702 +/- ##
==========================================
+ Coverage 87.88% 87.94% +0.06%
==========================================
Files 50 50
Lines 4241 4238 -3
==========================================
Hits 3727 3727
+ Misses 514 511 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 9b2f552. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on description and code review ✅
For off ipfs type messages we would not exceed pov, so I think it's safe to go with it for time being
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I downloaded the branch and ran make test and make start as well.
The two comments I have are non-blocking but that python script does deserve some explanation/comments at the top if you want to add it. It looks pretty generic looking, so I can't tell what it's meant to be used for.
Edit: also meant to note that I went through a couple of the parity PRs for comparison.
9b2f552
to
450d889
Compare
👍 looks great! |
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stupendous! 💯
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit d70798e. |
d70798e
to
c1ed2b6
Compare
Goal
The goal of this PR is to remove
without_storage_info
which is necessary to be able to calculate max encoded length for PoV.Closes
#1696
Changes
MaxEncodedLen
PoV for messages due to oversized PoV we would need to usemeasured
until we reworked the messages pallet.MessagesMaxPayloadSizeBytes
from 50K to 3K to reduce the chance of Oversized PoV even for measured mode until the rework of messages pallet.MessagesMaxPerBlock
from 7000 to 200 to reduce the chance of Oversized PoV even for measured mode until the rework of messages pallet.Checklist
Notes
I checked all the submitted messages on rococo and main-net and there are no messages that violate these restrctions
Here is list of all messages on rococo and there are none on main-net. The biggest one has less than 700 bytes
messages.txt
Merge order
This most probably will get merged after node upgrade PR unless something changes