Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting system information #5

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Conversation

frenck
Copy link
Owner

@frenck frenck commented Dec 28, 2021

Proposed Changes

Adds support for retrieving system information

@frenck frenck added the new-feature New features or options. label Dec 28, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 28, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.05%.

Quality metrics Before After Change
Complexity 1.20 ⭐ 0.94 ⭐ -0.26 👍
Method Length 40.45 ⭐ 44.48 ⭐ 4.03 👎
Working memory 5.82 ⭐ 5.79 ⭐ -0.03 👍
Quality 82.05% 81.00% -1.05% 👎
Other metrics Before After Change
Lines 343 423 80
Changed files Quality Before Quality After Quality Change
src/pvo/init.py 96.17% ⭐ 95.84% ⭐ -0.33% 👎
src/pvo/models.py 92.83% ⭐ 92.41% ⭐ -0.42% 👎
src/pvo/pvoutput.py 74.71% 🙂 76.41% ⭐ 1.70% 👍
tests/test_pvoutput.py 83.76% ⭐ 81.10% ⭐ -2.66% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/pvo/pvoutput.py PVOutput._request 6 ⭐ 128 😞 9 🙂 61.53% 🙂 Try splitting into smaller methods
tests/test_pvoutput.py test_get_system 0 ⭐ 133 😞 6 ⭐ 73.90% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@frenck frenck merged commit 89fd5d7 into main Dec 28, 2021
@frenck frenck deleted the frenck-2021-3361 branch December 28, 2021 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant