Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of normalized output name #4

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Fix spelling of normalized output name #4

merged 1 commit into from
Dec 28, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Dec 28, 2021

Proposed Changes

Oops

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Dec 28, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 28, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.22 ⭐ 1.22 ⭐ 0.00
Method Length 41.68 ⭐ 41.68 ⭐ 0.00
Working memory 5.84 ⭐ 5.84 ⭐ 0.00
Quality 81.89% 81.89% 0.00%
Other metrics Before After Change
Lines 327 327 0
Changed files Quality Before Quality After Quality Change
src/pvo/models.py 92.83% ⭐ 92.83% ⭐ 0.00%
src/pvo/pvoutput.py 74.71% 🙂 74.71% 🙂 0.00%
tests/test_pvoutput.py 83.76% ⭐ 83.76% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/pvo/pvoutput.py PVOutput._request 6 ⭐ 128 😞 9 🙂 61.53% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov-commenter
Copy link

Codecov Report

Merging #4 (b9d3d6e) into main (ad54f8d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files           4        4           
  Lines          82       82           
  Branches       12       12           
=======================================
  Hits           79       79           
  Misses          2        2           
  Partials        1        1           
Impacted Files Coverage Δ
src/pvo/pvoutput.py 93.75% <ø> (ø)
src/pvo/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad54f8d...b9d3d6e. Read the comment docs.

@frenck frenck merged commit e6d4971 into main Dec 28, 2021
@frenck frenck deleted the frenck-2021-3360 branch December 28, 2021 11:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants