Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching mac address & Wi-Fi information #695

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

frenck
Copy link
Owner

@frenck frenck commented Feb 4, 2023

Proposed Changes

Noticed newer firmware versions provide their mac address and Wi-Fi information in their device info. Extended the library to support that.

../Frenck

@frenck frenck added the new-feature New features or options. label Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #695 (465d326) into main (80ca474) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #695   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          136       142    +6     
  Branches        17        17           
=========================================
+ Hits           136       142    +6     
Impacted Files Coverage Δ
src/elgato/models.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@frenck frenck merged commit 778ea78 into main Feb 4, 2023
@frenck frenck deleted the frenck-2023-0266 branch February 4, 2023 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants