Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclass instead of constructor #387

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Use dataclass instead of constructor #387

merged 1 commit into from
Oct 7, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented Oct 7, 2021

Proposed Changes

Use a dataclass instead of a class constructor, which solves a flake8 detected issue.

@frenck frenck added the refactor Improvement of existing code, not introducing new features. label Oct 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #387 (fd843d6) into main (9fa4712) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          133       134    +1     
  Branches        18        19    +1     
=========================================
+ Hits           133       134    +1     
Impacted Files Coverage Δ
src/elgato/elgato.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa4712...fd843d6. Read the comment docs.

@frenck frenck merged commit 97ccbcc into main Oct 7, 2021
@frenck frenck deleted the frenck-2021-2537 branch October 7, 2021 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants