Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Light Strip, name changes, Idenfity and Settings #280

Merged
merged 2 commits into from
May 2, 2021

Conversation

frenck
Copy link
Owner

@frenck frenck commented May 1, 2021

Proposed Changes

Quite a larger update of this library.

  • Since we support multiple "Light" devices now (and not just the Elgato Key Light), all occurrences of "Key Light" have been replaced by "Light".
  • Added support for the Elgato Light Strip
    • This adds support for colors
    • Allow using the Light Strip with temperature values as well
  • Updated all sub dependencies
  • Added ways to read device settings (which can be used to figure out if the device supports color)
  • Added method to blink an Elgato light: Identify
  • Added additional validation to the light calls for invalid data
  • Kept test coverage at 100%

closes #279

@frenck frenck added documentation Solely about the documentation of the project. dependencies Upgrade or downgrade of project dependencies. new-feature New features or options. labels May 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #280 (157abdd) into main (9c8708b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #280   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           87       133   +46     
  Branches         9        18    +9     
=========================================
+ Hits            87       133   +46     
Impacted Files Coverage Δ
src/elgato/exceptions.py 100.00% <ø> (ø)
src/elgato/__init__.py 100.00% <100.00%> (ø)
src/elgato/elgato.py 100.00% <100.00%> (ø)
src/elgato/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8708b...157abdd. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2021

This pull request introduces 1 alert when merging 8f43269 into 9c8708b - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@frenck frenck merged commit f18cdfc into main May 2, 2021
@frenck frenck deleted the frenck-2021-1350 branch May 2, 2021 08:55
@lgtm-com
Copy link

lgtm-com bot commented May 2, 2021

This pull request introduces 1 alert when merging 157abdd into 9c8708b - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. documentation Solely about the documentation of the project. new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Elgato Light Strip
2 participants