Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize job depends on check-version #914

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

magecnion
Copy link
Contributor

No description provided.

asiniscalchi
asiniscalchi previously approved these changes Dec 13, 2024
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Member

@asiniscalchi asiniscalchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^v[0-9][0-9]?\.[0-9][0-9]?\.([0-9]|[0-8][0-9])$

echo "v50.4.2" | grep -E '^v[0-9]{1,2}\.[0-9]{1,2}\.(?:[0-9]|[1-8][0-9])$' doesn't match

luispdm
luispdm previously approved these changes Dec 13, 2024
@magecnion
Copy link
Contributor Author

^v[0-9][0-9]?.[0-9][0-9]?.([0-9]|[0-8][0-9])$

Right, I put: ^v[0-9][0-9]?\.[0-9][0-9]?\.([0-9]|[1-8][0-9])$ instead, otherwise v50.40.09 would match and it is not correct.

@magecnion magecnion merged commit c1e4e01 into main Dec 13, 2024
10 checks passed
@magecnion magecnion deleted the ci/docker-job-and-release-are-parallel branch December 13, 2024 11:32
@luispdm luispdm linked an issue Dec 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and push Docker images for dev versions
3 participants