Refactor Runtime APIs Implementation and Update Import Paths #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/describe |
|
PR Description updated to latest commit (aeb8188) |
ccubu
previously approved these changes
Mar 25, 2024
magecnion
reviewed
Mar 25, 2024
| @@ -122,7 +110,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| authoring_version: 1, | |||
| spec_version: 1201, | |||
| impl_version: 0, | |||
| apis: RUNTIME_API_VERSIONS, | |||
| apis: apis::PUBLIC_RUNTIME_API_VERSIONS, | |||
There was a problem hiding this comment.
it might sound like too much, but do you think it is worth adding a test for the apis::PUBLIC_RUNTIME_API_VERSIONS value? so we ensure it doesn't change. If not why?
There was a problem hiding this comment.
yes, not nice: it's forced by the fact that the macro defines RUNTIME_API_VERSIONS not public. I am trying to expose the problem to the polkadot-sdk guys. We'll see if they accept it.
We can choose another name for sure... :D
ghost
approved these changes
Mar 25, 2024
magecnion
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
enhancement
Description
laos_runtimefrom using macros to direct coding, enhancing readability and maintainability.RuntimeApiand dispatch method innode/src/service.rsto align with the new structure.apismodule public inruntime/laos/src/lib.rsand updated the runtime versioning to useapis::PUBLIC_RUNTIME_API_VERSIONS.Changes walkthrough
service.rs
Update Runtime API Import Paths and Dispatch Methodnode/src/service.rs
RuntimeApiupdated tolaos_runtime::apis::RuntimeApi.laos_runtime::apis::api::dispatchinstead oflaos_runtime::api::dispatch.apis.rs
Refactor Runtime APIs Implementation from Macro to Direct Codingruntime/laos/src/apis.rs
and structures.
PUBLIC_RUNTIME_API_VERSIONSfor exposing runtime APIversions.
lib.rs
Expose APIs Module and Update Runtime Versioningruntime/laos/src/lib.rs
apismodule public.VERSIONto useapis::PUBLIC_RUNTIME_API_VERSIONSfor APIversions.
impl_runtime_apis_plus!();.