Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fill_value to handle missing chunks #34

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Use fill_value to handle missing chunks #34

merged 6 commits into from
Mar 23, 2022

Conversation

katamartin
Copy link
Collaborator

@katamartin katamartin commented Mar 22, 2022 •
edited
Loading

Return chunk containing metadata.fill_value instead of erroring when a chunk is missing

  • When using server requests, this is triggered by a 404 status code
  • When using fs.readFile, this is triggered by an ENOENT code

Note that when fill_value is missing, this will return a chunk containing undefined values.

closes #32

@katamartin katamartin requested a review from freeman-lab March 22, 2022 22:14
@freeman-lab
Copy link
Owner

reviewing now, one quick thing is we should probably add entries to the data generation script to generate these new files

@katamartin katamartin merged commit 9b4fdfe into master Mar 23, 2022
@katamartin katamartin deleted the katamartin/fill-value branch March 23, 2022 16:16
@katamartin katamartin mentioned this pull request May 23, 2022
Open
@katamartin katamartin mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

@freeman-lab freeman-lab Awaiting requested review from freeman-lab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle missing chunks
3 participants
@katamartin @freeman-lab @andersy005