Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to run node shell on Bootlerocket and Windows nodes #147

Merged

Conversation

dex4er
Copy link
Collaborator

@dex4er dex4er commented Feb 13, 2025

This is a reworked node-shell feature. It allows to run it on Bottlerocket OS and Windows nodes where there is no sh nor bash command.

Unfortunately, node-shell pods cannot be autoremoved anymore with sleep command. It is because now single pod is created and then kubectl attach is run. It is because kubectl exec with nsenter command won't work: Bottlerocket OS is SELinux hardened then nsenter won't have privileges to run in kubectl exec context.

Bottlerocket OS:

image

Windows 2022:

image

@dex4er dex4er self-assigned this Feb 13, 2025
@dex4er dex4er added the enhancement New feature or request label Feb 13, 2025
@dex4er dex4er merged commit 445892b into freelensapp:main Feb 13, 2025
9 checks passed
@dex4er dex4er deleted the feat/node-shell-bottlerocket-and-windows branch February 13, 2025 22:22
@dex4er dex4er added this to the v1.0.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant