fix(guam): date regex was picking wrong values #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves freelawproject#789 - Validated and improved regexes for date, docket and citation
flooie
reviewed
Jan 26, 2024
Comment on lines
51
to
57
| date = self.find_date(text) | ||
| if not date: | ||
| logger.error( | ||
| "Could not find date for record in guam scraper Year: %s", | ||
| self._year, | ||
| ) | ||
| continue |
There was a problem hiding this comment.
do you know about date_filed_is_approximate
If we cant find the date, but we can find the year and month we usually assign the date to the 15th of the month and year and set date_filed_is_approximate to True,
if we only find the year - we can do the same - but assign the date to the middle of the year and state if date_filed_is_approximate = True again
There was a problem hiding this comment.
I have updated the PR using date_filed_is_approximate, please check again
flooie
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #789