Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cal-ag): Fix Cal AG #881

Merged
merged 7 commits into from
Jan 25, 2024
Merged

fix(cal-ag): Fix Cal AG #881

merged 7 commits into from
Jan 25, 2024

Conversation

flooie
Copy link
Contributor

@flooie flooie commented Jan 24, 2024

Add custom SSL adapter to make connections to server possible.

@flooie
fix(cal-ag): Fix Cal AG
386b2b6 
Use custom SSL adapter
@flooie flooie requested a review from grossir January 24, 2024 16:23
@flooie
Copy link
Contributor Author

flooie commented Jan 24, 2024

Should resolve issue #814

grossir
grossir previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@grossir grossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine on juriscraper. Will need to be tested when integrated into courtlistener for the get_binary_content stage

I noticed an enhancement opportunity while testing, see #884

@flooie
fix(cal-ag): Convert CAL AG to opinionsitelinear
b36404d 
Add citations
Improve case name
Streamline collection
Update tests
@flooie flooie requested a review from grossir January 24, 2024 19:19
@flooie
Copy link
Contributor Author

flooie commented Jan 24, 2024

@grossir could you re-review this please. In light of your comments - I thought it best to just clean it up and add citations.

@flooie
Copy link
Contributor Author

flooie commented Jan 24, 2024

this should now fix #884

grossir
grossir reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@grossir grossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a change needed in this PR, but eyecite will need an update to parse this citation format. Currently:

from eyecite import get_citations
get_citations('106 Ops.Cal.Atty.Gen. 1')
> []

@flooie
Copy link
Contributor Author

flooie commented Jan 25, 2024

This is not a change needed in this PR, but eyecite will need an update to parse this citation format. Currently:

from eyecite import get_citations
get_citations('106 Ops.Cal.Atty.Gen. 1')
> []

Thanks - I bumped reporters-db so it should be good to go the next time we bump CL

@flooie flooie merged commit 18a04f4 into main Jan 25, 2024
14 checks passed
@flooie flooie deleted the fix-cal-ag branch January 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossir grossir grossir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flooie @grossir