fix(pacer.email): plain text parsing of bankruptcy short description #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of order of statements, parsing of bankruptcy short description was failing when trying to access the 0 index of the empty list self.docket_numbers Also added - a plain text test case for cob - short description parsing case for cob - logger.error calls for when we are not prepared to parse a bankruptcy short description Solves freelawproject#729
|
Alberto, can you please review this one when you have a moment? |
albertisfu
requested changes
Jan 23, 2024
albertisfu
reviewed
Jan 23, 2024
…ents_plain - _contains_attachments_plain was always returning False, even when True - _get_description_plain updated regex for format seen in cob - Updated test cases: almd_4_plain.txt had a duplicated document paragraph
albertisfu
reviewed
Jan 30, 2024
for more information, see https://pre-commit.ci
…ossir/juriscraper into fix_recap_email_plain_text_bankruptcy
|
@albertisfu please check again |
albertisfu
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks, this looks good now to me. It seems ready for merging. @mlissner
|
Lovely. Thank you guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of order of statements, parsing of bankruptcy short description was failing when trying to access the 0 index
of the empty list self.docket_numbers
Also added
Solves #729
Solves #866