Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires coverage >= 5.0 #6092

Merged
merged 1 commit into from
Sep 8, 2021
Merged

requires coverage >= 5.0 #6092

merged 1 commit into from
Sep 8, 2021

Conversation

cfm
Copy link
Member

@cfm cfm commented Sep 7, 2021

Status

Ready for review

Description of Changes

Fixes #6091 by requiring coverage ≥ 5.0, to include nedbat/coveragepy#724.

The alternative appears to be to wait for setuptools > 58.0.2, per pypa/setuptools#2777. But this seems like the more-forward way.

Testing

  • admin-tests passes.

Deployment

Development- and test-only; no deployment implications.

Checklist

If you added or updated a code dependency:

coverage is used in development and test environments only; no diff review required.

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

The alternative appears to be to wait for setuptools > 58.0.2, per
pypa/setuptools#2777.  But this seems like the more-forward way.
@cfm cfm requested a review from a team as a code owner September 7, 2021 22:52
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green - no diff review required as this dep is dev-only.

@zenmonkeykstop zenmonkeykstop merged commit 7fff9f9 into develop Sep 8, 2021
@zenmonkeykstop zenmonkeykstop deleted the 6091-broken-setuptools branch September 8, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin-tests failing with Setuptools 58.0.2
2 participants