Run CI using GitHub Actions #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cfm
requested changes
Apr 24, 2023
There was a problem hiding this comment.
I like this a lot, @legoktm. Even though this is the (or a) point of this effort, it's still surprisingly nice to have the CI checks visible directly in GitHub: faster, more responsive, and lower-friction.
I've left a few stylistic nits inline.
This is a basically identical port of the existing CircleCI jobs to GitHub Actions. The linkcheck job is configured separately since it runs on a cron rather than on push/PR. Refs <freedomofpress/securedrop-tooling#5>.
|
Done, switched to long/full options (and will keep that in mind for future PRs :)). |
cfm
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This is a basically identical port of the existing CircleCI jobs
to GitHub Actions.
The linkcheck job is configured separately since it runs on a cron
rather than on push/PR.
Refs freedomofpress/securedrop-tooling#5.
Testing