Allow to fix ownership and permission on files copied from the overla… #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to issue #1181 |
evadot
reviewed
Jan 27, 2025
src/share/poudriere/image.sh
Outdated
| @@ -58,7 +58,8 @@ Options: | |||
| the disk image and mount it to \$WRKDIR/world before | |||
| installing the contents to the image | |||
| -c overlaydir -- The content of the overlay directory will be copied into | |||
| the image | |||
| the image. Owners and permissions will be overwritten if | |||
| an overlaydir.mtree file is found | |||
There was a problem hiding this comment.
A bit confusing as people might think that the file needs to be strictly named 'overlaydir.mtree'
There was a problem hiding this comment.
Could using $overlaydir.mtree enough to solve this confusion ?
There was a problem hiding this comment.
but how the user will know where to put the.mtree file ?
There was a problem hiding this comment.
Stupid github, that was supposed to be <overlaydir>.mtree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y directory.