-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a warning for installing sway #443
Conversation
Hi. I don't think it's best to put the warning at the start of the section. Maybe it would fit better later on, where it seems more natural. Also, there is already a link at the beginning of this chapter to 'How to Identify and Configure Drivers for Your Graphics Hardware' that might be useful. |
I didn't know about that chapter in the book, however it still makes sense to at least warn user before they install Sway and try to run it. maybe we should point the user to that chapter saying "please read this section before installing sway" |
Can you please change your patch to make this change? |
I have changed the commit and now it points the user to section 'How to Identify and Configure Drivers for Your Graphics Hardware'. I hope it will be useful for someone. |
@@ -370,6 +370,11 @@ To start Hikari, use the following command: | |||
[[wayland-sway]] | |||
== The Sway Compositor | |||
|
|||
[NOTE] | |||
==== | |||
Make sure you have read this section 'How to Identify and Configure Drivers for Your Graphics Hardware'. otherwise it would give error "0 GPU detected". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make that a link, as explained in https://docs.freebsd.org/en/books/fdp-primer/asciidoctor-primer/#_links_to_the_same_file_or_to_another_file_in_the_same_book .
@dbaio I like how you have done it. It feels much more natural than putting it inside can I add the changes given by you into my pull request? |
Yes, please. I can push this PR to the tree tonight or tomorrow |
Reported by: https://github.com/Ghodawalaaman Pull Request: #443
Thanks, this has been submitted to the tree. |
No description provided.