Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/make-release.sh: automate release creation #74

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

ngie-eign
Copy link
Contributor

@ngie-eign ngie-eign commented Nov 28, 2024

This does the absolute bare minimum to produce a release.

This logic best resembles the expectations for legacy (pre-0.22) releases
of ATF.

Various files are omitted as they are not required in order to build
from a full autoreconf'ed source distribution.

@ngie-eign ngie-eign requested a review from emaste November 28, 2024 21:05
@ngie-eign ngie-eign force-pushed the automake-release-creation branch from 1d02ff8 to 62926b6 Compare November 28, 2024 21:10
@ngie-eign ngie-eign changed the title admin/make-release.sh: automate release creation admin/make-release.zsh: automate release creation Nov 28, 2024
@ngie-eign
Copy link
Contributor Author

Please ignore the typo in the branch name 🙏 ...

@ngie-eign ngie-eign force-pushed the automake-release-creation branch from 62926b6 to c87fe3e Compare December 1, 2024 21:31
@ngie-eign ngie-eign requested a review from ihoro December 25, 2024 22:07
@ngie-eign ngie-eign force-pushed the automake-release-creation branch from c87fe3e to 215afd3 Compare December 28, 2024 04:35
@ngie-eign ngie-eign requested a review from ihoro December 28, 2024 04:37
@ngie-eign ngie-eign force-pushed the automake-release-creation branch 2 times, most recently from 3cb3cba to b9539df Compare December 28, 2024 04:42
@ngie-eign ngie-eign changed the title admin/make-release.zsh: automate release creation admin/make-release.sh: automate release creation Dec 28, 2024
@ngie-eign ngie-eign force-pushed the automake-release-creation branch from b9539df to 4105629 Compare December 28, 2024 05:00
This does the absolute bare minimum to produce a release.

This logic best resembles the expectations for legacy (pre-0.22) releases
of ATF.

Various files are omitted as they are not required in order to build
from a full `autoreconf`'ed source distribution.

Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
@emaste
Copy link
Member

emaste commented Dec 28, 2024

looks good, same comments as in freebsd/kyua#252

@ngie-eign
Copy link
Contributor Author

ngie-eign commented Dec 28, 2024

@emaste : please note that I used a fixup commit here to ease review, so this will need to be squashed before merge. It's a practice I want to get into doing more because it makes reviews easier for reviewers.

@ngie-eign
Copy link
Contributor Author

TIL: rebase merges with --fixup commits don't use --autosquash: https://github.com/ngie-eign/github-test-repo/commits/main/ (seems like a bit of a bug to me).

@ngie-eign ngie-eign merged commit defa677 into freebsd:master Dec 28, 2024
@ngie-eign ngie-eign deleted the automake-release-creation branch December 28, 2024 17:55
ngie-eign added a commit that referenced this pull request Mar 29, 2025
* admin/make-release.sh: automate release creation

This does the absolute bare minimum to produce a release.

This logic best resembles the expectations for legacy (pre-0.22) releases
of ATF.

Various files are omitted as they are not required in order to build
from a full `autoreconf`'ed source distribution.

Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants