Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATF is incompatible with capsicum #45

Closed
asomers opened this issue Jul 21, 2019 · 7 comments
Closed

ATF is incompatible with capsicum #45

asomers opened this issue Jul 21, 2019 · 7 comments

Comments

@asomers
Copy link
Member

asomers commented Jul 21, 2019

@jansucan discovered that if an ATF test case enters capability mode with cap_enter, then it won't be able to write the results file. It seems like this would be easy to fix, but simply opening up the results file at the top of atf_tc_run. Thoughts? cc @jmmv @ngie-eign .

@cemeyer
Copy link
Member

cemeyer commented Aug 7, 2019

I discovered and fixed this in 2017: cemeyer@317c806 . Jmmv won't take my change because I can't sign Google's CLA on my employer's behalf.

@asomers
Copy link
Member Author

asomers commented Aug 7, 2019

That's lame. Do we need to fork atf?

@cemeyer
Copy link
Member

cemeyer commented Aug 7, 2019

Sure, a freebsd/atf fork is fine with me. If jmmv's fork has activity (it's pretty idle) we can always pull new material down.

@asomers
Copy link
Member Author

asomers commented Aug 7, 2019

Who has the authority to create new repos in the freebsd organization?

@cemeyer
Copy link
Member

cemeyer commented Aug 7, 2019

Not me. I'd ask Ed.

@krytarowski
Copy link

krytarowski commented Feb 9, 2020

What is new with this fork? In NetBSD I would love to rely on plain C rather than fancy C++. C++ creates some burden on the system. It happened to be harder to get C++ right, sanitized etc than execute some preexisting regression tests that are mostly C code.

@cemeyer
Copy link
Member

cemeyer commented Feb 10, 2020

I doubt we would make any immediate move away from C++.

cemeyer referenced this issue in freebsd/atf-fork Sep 6, 2020
Fix #45: Preopen result files before running testcases
@lwhsu lwhsu closed this as completed in 4581cef Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants