Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish v13 #142

Merged
merged 1 commit into from
Jan 11, 2024
Merged

publish v13 #142

merged 1 commit into from
Jan 11, 2024

Conversation

joelmccracken
Copy link
Contributor

I missed the finishing touches required to publish this version.

version: 1.12.0.0
version: 1.13.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels aggressive. Nothing about any of the code-level interfaces have changed. As far as I can tell, this is a bugfix or maybe an addition. I'd go v1.12.0.1, myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, i'll do that, np. I figured adding the other metric was considered an addition, but I really wanted to do this so.

Copy link
Member

@pbrisbin pbrisbin Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it were an addition that'd only be 1.12.1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe I need to refresh on how haskell's PVP works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it documented here: https://illuminate.atlassian.net/wiki/spaces/EN/pages/17185952648/Maintaining+Haskell+Open+Source#Versioning

We do SemVer in the last 3 components and treat the 1st component as an overall "epoch". We like this because you can think in SemVer while still implicitly satisfying PVP, thus side-stepping a lot of flame wars about it.

@joelmccracken joelmccracken merged commit e0212a3 into main Jan 11, 2024
5 of 6 checks passed
@joelmccracken joelmccracken deleted the jnm/publish-v13 branch January 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants