Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow renaming account while system is actively in use (backport #46176) #46209

Open
wants to merge 1 commit into
base: version-14-hotfix
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 28, 2025

Don't allow renaming if accounting entries are actively being updated, there are two main reasons:

  1. Correctness: It's next to impossible to ensure that the renamed account is not being used right now.
  2. Performance: Renaming requires locking out many tables entirely and severely degrades performance.

image


This is an automatic backport of pull request #46176 done by [Mergify](https://mergify.com).

…6176)

(cherry picked from commit 999f1cf)

# Conflicts:
#	erpnext/accounts/doctype/account/account.py
Copy link
Contributor Author

mergify bot commented Feb 28, 2025

Cherry-pick of 999f1cf has failed:

On branch mergify/bp/version-14-hotfix/pr-46176
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 999f1cf96d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/account/account.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant