fix: validations and account type filter for Tax Withholding Category
#46207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances validation logic to prevent overlapping date ranges and duplicate company entries in the system.
Before
Users could add multiple rate rows with overlapping date ranges.
• Example:
• Row 1: From 01/04/2024 → To 31/03/2025
• Row 2: From 01/05/2024 → To 31/05/2024
•The system previously allowed this, leading to incorrect data.
A user could add the same company multiple times with different accounts, which caused redundancy and data inconsistencies.
After
✅ Fixed Overlapping Date Validation
• The system now throws an error if a user tries to add a rate row with overlapping dates.
✅ Prevented Duplicate Company Entries
• A company can now only be added once.