Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use value from currency exchange when exchange api is disabled #46137

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

venkat102
Copy link
Contributor

Issue:
exchange rate not fetching from the currency exchange when exchange API setting is disabled.
ref: 32635

Steps to reproduce:

  • Create company with Currency AED
  • Disable exchange API setting
  • Create a currency exchange with From currency USD, To currency AED and exchange rate as 3.67.
  • Create a Invoice with party currency as USD
  • Exchange rate will be fetched as 3.6725 instead of 3.67.

Before:

exchange-rate-issue.mp4

After:

exchange-rate-fix.mp4

Back port needed for v15

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant