Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Debit and Credit mismatch on transaction currency debit and credit values #46064

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Feb 21, 2025

Issue

Debit and Credit values in Transaction currency have a slight mismatch on high precision exchange rates. This is un-fixable on the current approach.
Screenshot from 2025-02-19 11-39-23

Solution

Instead of calculating Transaction Debit and Credit from base currency, use values directly from parent document.

todo:

  • handle divisional loss GL entries in purchase invoice
  • sales invoice
  • journal entry
  • payment entry

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Feb 21, 2025
@ruthra-kumar ruthra-kumar force-pushed the transaction_currency_from_parent_document branch from 4fd1f4c to 6b3e7d4 Compare February 28, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant