Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong paid and cn amount on pos invoice #38797

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: wrong paid and cn amount on pos invoice #38797

merged 2 commits into from
Dec 19, 2023

Conversation

rtdany10
Copy link
Contributor

Closes #38130

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 16, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2023 •
edited
Loading

Codecov Report

Merging #38797 (40305ca) into develop (591f4eb) will decrease coverage by 7.17%.
Report is 195 commits behind head on develop.
The diff coverage is 100.00%.

❗ Current head 40305ca differs from pull request most recent head 8772628. Consider uploading reports for the commit 8772628 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #38797      +/-   ##
===========================================
- Coverage    67.25%   60.09%   -7.17%     
===========================================
  Files          760      759       -1     
  Lines        60853    69569    +8716     
===========================================
+ Hits         40928    41808     +880     
- Misses       19925    27761    +7836
Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 89.73% <100.00%> (+0.05%) ⬆️

... and 511 files with indirect coverage changes

@rtdany10
Copy link
Contributor Author

@ruthra-kumar @deepeshgarg007

@rtdany10
Copy link
Contributor Author

@ruthra-kumar

@ruthra-kumar ruthra-kumar self-assigned this Dec 19, 2023
@ruthra-kumar ruthra-kumar removed the needs-tests This PR needs automated unit-tests. label Dec 19, 2023
@rtdany10
Copy link
Contributor Author

Looks like unrelated test failure, @ruthra-kumar

@rtdany10
Copy link
Contributor Author

Please backport to v14, v15 also

@ruthra-kumar ruthra-kumar merged commit dd6c192 into frappe:develop Dec 19, 2023
This was referenced Dec 19, 2023
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Dec 19, 2023
@ruthra-kumar
Merge pull request #38844 from frappe/mergify/bp/version-15-hotfix/pr…
637343f 
…-38797

fix: wrong paid and cn amount on pos invoice (backport #38797)
ruthra-kumar added a commit that referenced this pull request Dec 19, 2023
@ruthra-kumar
Merge pull request #38843 from frappe/mergify/bp/version-14-hotfix/pr…
61b02ec 
…-38797

fix: wrong paid and cn amount on pos invoice (backport #38797)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruthra-kumar ruthra-kumar ruthra-kumar approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong receivables when invoice is partly paid from POS
2 participants
@rtdany10 @ruthra-kumar