Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Purchase Register): show bill_date and bill_no #38742

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(Purchase Register): show bill_date and bill_no #38742

merged 1 commit into from
Dec 15, 2023

Conversation

ljain112
Copy link
Collaborator

Values were not assigned for bill_date and bill_no.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 14, 2023
@ljain112 ljain112 mentioned this pull request Dec 14, 2023
Closed
1 task
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #38742 (f53ba17) into develop (6851c50) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #38742   +/-   ##
========================================
  Coverage    60.07%   60.07%           
========================================
  Files          759      759           
  Lines        69547    69553    +6     
========================================
+ Hits         41780    41785    +5     
- Misses       27767    27768    +1
Files Coverage Δ
...e/payment_reconciliation/payment_reconciliation.py 86.14% <100.00%> (+0.25%) ⬆️
...unts/report/purchase_register/purchase_register.py 86.33% <ø> (ø)

... and 1 file with indirect coverage changes

@barredterra barredterra merged commit a9a84cc into frappe:develop Dec 15, 2023
@barredterra barredterra added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Dec 15, 2023
@barredterra barredterra changed the title fix: show bill_date and bill_no in Purchase Register fix(Purchase Register): show bill_date and bill_no Dec 15, 2023
This was referenced Dec 15, 2023
Closed
Merged
barredterra added a commit that referenced this pull request Dec 15, 2023
@barredterra
Merge pull request #38787 from frappe/mergify/bp/version-15-hotfix/pr…
a70be42 
…-38742

fix(Purchase Register): show bill_date and bill_no (backport #38742)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barredterra barredterra barredterra approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljain112 @barredterra