Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provision to add items in Stock Reservation dialog #38558

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Dec 4, 2023

scrnli_12_4_2023_6-09-06.PM.mp4

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (15fff84) 60.16% compared to head (8d5045e) 60.16%.
Report is 151 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38558      +/-   ##
===========================================
- Coverage    60.16%   60.16%   -0.01%     
===========================================
  Files          759      759              
  Lines        69470    69485      +15     
===========================================
+ Hits         41797    41803       +6     
- Misses       27673    27682       +9     
Files Coverage Δ
...ange_rate_revaluation/exchange_rate_revaluation.py 88.21% <100.00%> (ø)
erpnext/accounts/party.py 81.12% <100.00%> (ø)
...e_purchase_register/item_wise_purchase_register.py 58.94% <ø> (ø)
erpnext/selling/doctype/customer/customer.py 66.30% <ø> (ø)
...serial_and_batch_bundle/serial_and_batch_bundle.py 71.14% <66.66%> (-0.02%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 84.14% <55.55%> (ø)
erpnext/controllers/queries.py 56.44% <25.00%> (-1.12%) ⬇️
...n_summary/sales_person_wise_transaction_summary.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@stale stale bot added the inactive label Dec 20, 2023
@frappe frappe deleted a comment from stale bot Dec 20, 2023
@stale stale bot removed the inactive label Dec 20, 2023
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Dec 22, 2023
@s-aga-r s-aga-r marked this pull request as ready for review December 22, 2023 06:44
@s-aga-r s-aga-r merged commit d0ed8ef into frappe:develop Dec 22, 2023
s-aga-r added a commit that referenced this pull request Dec 22, 2023
…8558) (#38920)

* feat: provision to update items in Stock Reservation dialog

(cherry picked from commit 9471d8f)

* fix(ux): show row index and field label while selecting the Sales Order Item

(cherry picked from commit 0026109)

* feat: provision to add items in Stock Reservation dialog

(cherry picked from commit 8d5045e)

---------

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 27, 2023
# [15.8.0](v15.7.0...v15.8.0) (2023-12-27)

### Bug Fixes

* `Reserved Stock` report (backport [#38922](#38922)) ([#38924](#38924)) ([8f643f0](8f643f0))
* allow to set rate manually for service item in BOM (backport [#38880](#38880)) (backport [#38882](#38882)) ([#38885](#38885)) ([74606dc](74606dc))
* do not make serial batch bundle for zero qty (backport [#38949](#38949)) ([#38954](#38954)) ([a41cf62](a41cf62))
* do not reset the basic rate for the material receipt stock entry (backport [#38896](#38896)) ([#38899](#38899)) ([f6eb2b5](f6eb2b5))
* incorrect price list in customer-wise item price report ([e0dbb57](e0dbb57))
* incorrect qty in serial batch bundle against pick list (backport [#38964](#38964)) ([#38966](#38966)) ([5874be0](5874be0))
* local reference error in BOM (backport [#38850](#38850)) ([#38877](#38877)) ([e3be9c1](e3be9c1))
* min order qty optional in production plan (backport [#38956](#38956)) ([#38958](#38958)) ([ab9fce3](ab9fce3))
* not able to import serial batch bundle using csv (backport [#38950](#38950)) ([#38955](#38955)) ([0e48ef7](0e48ef7))
* reposting not fixing valuation rate for sales return using movin… (backport [#38895](#38895)) (backport [#38897](#38897)) ([#38901](#38901)) ([eabb956](eabb956))
* reset the incoming rate on changing of the warehouse (backport [#38925](#38925)) ([#38926](#38926)) ([82960e3](82960e3))
* **test:** expect account currency when party account is specified. ([2d9a0a8](2d9a0a8))
* typeerror on pos order summary to new order screen ([bf98a8f](bf98a8f))
* typerror on tree doctypes - Item Group, Customer Group, Supplier Group and Territory (backport [#38870](#38870)) ([#38871](#38871)) ([d75ac13](d75ac13))
* use party account currency when party account is specified ([32d3d4e](32d3d4e))
* **ux:** make PR and PI Item rate field readonly based on `Maintain Same Rate` (backport [#38942](#38942)) ([#38944](#38944)) ([f704ccb](f704ccb))

### Features

* in_party_currency option for AR/AP reports ([a65bc77](a65bc77))
* provision to add items in Stock Reservation dialog (backport [#38558](#38558)) ([#38920](#38920)) ([8c2c90f](8c2c90f))
* total_asset_cost field (backport [#38879](#38879)) ([#38887](#38887)) ([58f1df5](58f1df5))

### Performance Improvements

* Drop unused/duplicate/sub-optimal indexes (backport [#38884](#38884)) ([#38913](#38913)) ([308c6ff](308c6ff))
* use estimated rows instead of actual rows (backport [#38830](#38830)) ([#38876](#38876)) ([648f275](648f275))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant