Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor): financial statements period end date #38556

Merged

Conversation

GursheenK
Copy link
Member

Bug
In Financial Statement Reports like Profit and Loss Statement, if the records are filtered based on Fiscal year and the periodicity is set to Monthly, Quarterly or Half Yearly, the report shows incorrect values for the months that come after the current date.

Screenshot

Current date is in Dec 2023, yet, for Jan - March 2024, values from Dec are added to the totals of the report.


Screenshot 2023-12-04 at 4 50 30 PM



Fix
Check for the period end date and limit it to the current date.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #38556 (ab6e92a) into develop (15fff84) will increase coverage by 0.00%.
Report is 10 commits behind head on develop.
The diff coverage is 40.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38556   +/-   ##
========================================
  Coverage    60.16%   60.16%           
========================================
  Files          759      759           
  Lines        69470    69474    +4     
========================================
+ Hits         41797    41801    +4     
  Misses       27673    27673           
Files Coverage Δ
...ange_rate_revaluation/exchange_rate_revaluation.py 88.21% <100.00%> (ø)
erpnext/accounts/party.py 81.12% <100.00%> (ø)
erpnext/accounts/report/financial_statements.py 80.49% <100.00%> (+0.06%) ⬆️
...e_purchase_register/item_wise_purchase_register.py 58.94% <ø> (ø)
erpnext/selling/doctype/customer/customer.py 66.30% <ø> (ø)
...serial_and_batch_bundle/serial_and_batch_bundle.py 71.14% <66.66%> (-0.02%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 84.14% <55.55%> (ø)
...n_summary/sales_person_wise_transaction_summary.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@GursheenK GursheenK merged commit 6812e91 into frappe:develop Dec 5, 2023
GursheenK added a commit that referenced this pull request Dec 5, 2023
…-38556

fix(minor): financial statements period end date (backport #38556)
deepeshgarg007 added a commit that referenced this pull request Dec 6, 2023
…-38556

fix(minor): financial statements period end date (#38556)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant