Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor): show party instead of party name where naming series not set #38144

Merged

Conversation

GursheenK
Copy link
Member

When Party Naming By is not set to Naming Series, show supplier / customer field values in Tax Withholding Details.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #38144 (b27af6b) into develop (7db1127) will increase coverage by 0.00%.
Report is 11 commits behind head on develop.
The diff coverage is 80.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38144   +/-   ##
========================================
  Coverage    67.26%   67.26%           
========================================
  Files          757      757           
  Lines        60487    60492    +5     
========================================
+ Hits         40684    40690    +6     
+ Misses       19803    19802    -1     
Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 83.66% <100.00%> (+0.05%) ⬆️
...tax_withholding_details/tax_withholding_details.py 80.00% <100.00%> (+0.12%) ⬆️
...t/manufacturing/doctype/bom_creator/bom_creator.py 80.18% <100.00%> (ø)
erpnext/selling/doctype/sales_order/sales_order.py 79.00% <50.00%> (ø)
erpnext/utilities/bulk_transaction.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@GursheenK GursheenK marked this pull request as ready for review November 17, 2023 07:37
@GursheenK GursheenK merged commit 8c6e341 into frappe:develop Nov 17, 2023
@GursheenK GursheenK removed the backport version-14-hotfix backport to version 14 label Dec 1, 2023
GursheenK added a commit that referenced this pull request Dec 1, 2023
…-38144

fix(minor): show party instead of party name where naming series not set (backport #38144)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant