Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add revaluation journal filter in Payable report #38119

Merged

Conversation

ruthra-kumar
Copy link
Member

continues: #38004

@ruthra-kumar ruthra-kumar force-pushed the missing_filter_in_payable_report branch from b9c76be to 0904e33 Compare November 16, 2023 04:49
@ruthra-kumar ruthra-kumar changed the title refactor: add revaluation journal filter in Payable report fix: add revaluation journal filter in Payable report Nov 16, 2023
@ruthra-kumar ruthra-kumar marked this pull request as ready for review November 16, 2023 04:52
@ruthra-kumar ruthra-kumar force-pushed the missing_filter_in_payable_report branch from 0904e33 to 7db1127 Compare November 16, 2023 12:25
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #38119 (7db1127) into develop (6e0362d) will decrease coverage by 0.15%.
Report is 27 commits behind head on develop.
The diff coverage is 1.13%.

❗ Current head 7db1127 differs from pull request most recent head 1342017. Consider uploading reports for the commit 1342017 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38119      +/-   ##
===========================================
- Coverage    67.40%   67.26%   -0.15%     
===========================================
  Files          757      757              
  Lines        60459    60487      +28     
===========================================
- Hits         40750    40684      -66     
- Misses       19709    19803      +94     
Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 89.83% <0.00%> (ø)
erpnext/accounts/utils.py 73.17% <50.00%> (-0.06%) ⬇️
erpnext/utilities/bulk_transaction.py 0.00% <0.00%> (-69.90%) ⬇️
...ctype/bulk_transaction_log/bulk_transaction_log.py 0.00% <0.00%> (-31.04%) ⬇️

... and 5 files with indirect coverage changes

@ruthra-kumar
Copy link
Member Author

@mergify backport version-14

Copy link
Contributor

mergify bot commented Nov 17, 2023

backport version-14

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Nov 17, 2023
…-38119

fix: add revaluation journal filter in Payable report (backport #38119)
ruthra-kumar added a commit that referenced this pull request Nov 17, 2023
…-38119

fix: add revaluation journal filter in Payable report (backport #38119)
ruthra-kumar added a commit that referenced this pull request Nov 17, 2023
fix: add revaluation journal filter in Payable report (backport #38119)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant