Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dn): regression from bulk transaction fix #38090

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Nov 14, 2023

I can't say how much every part of me rejects this implementation of a fix.

It's just more of the same flag-venom. But that's not end-user's fault.

Proper fix: frappe/frappe#23201


closes: #38072

regression caused by (fix): #37597

cc @s-aga-r

hotfix-15-backport

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #38090 (f9e29d1) into develop (c31ee8e) will increase coverage by 0.01%.
Report is 37 commits behind head on develop.
The diff coverage is 80.43%.

❗ Current head f9e29d1 differs from pull request most recent head 426c245. Consider uploading reports for the commit 426c245 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38090      +/-   ##
===========================================
+ Coverage    67.39%   67.40%   +0.01%     
===========================================
  Files          757      757              
  Lines        60449    60452       +3     
===========================================
+ Hits         40737    40747      +10     
+ Misses       19712    19705       -7     
Files Coverage Δ
erpnext/controllers/buying_controller.py 83.94% <ø> (ø)
...cturing/doctype/production_plan/production_plan.py 84.38% <ø> (ø)
...production_plan_summary/production_plan_summary.py 0.00% <ø> (ø)
...serial_and_batch_bundle/serial_and_batch_bundle.py 73.15% <100.00%> (+0.06%) ⬆️
...e/subcontracting_receipt/subcontracting_receipt.py 89.53% <ø> (ø)
erpnext/utilities/bulk_transaction.py 70.52% <100.00%> (+0.63%) ⬆️
erpnext/selling/doctype/sales_order/sales_order.py 78.85% <33.33%> (-0.28%) ⬇️
...ion_deletion_record/transaction_deletion_record.py 88.97% <86.95%> (ø)
erpnext/setup/doctype/employee/employee.py 59.16% <75.00%> (ø)

... and 4 files with indirect coverage changes

@s-aga-r s-aga-r added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Nov 16, 2023
@s-aga-r s-aga-r enabled auto-merge November 16, 2023 06:53
@s-aga-r s-aga-r merged commit 5cc8603 into frappe:develop Nov 16, 2023
deepeshgarg007 added a commit that referenced this pull request Nov 16, 2023
…-38090

fix(dn): regression from bulk transaction fix (#38090)
@blaggacao blaggacao deleted the fix/dn-mapper branch November 16, 2023 08:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V15] Issue in Delivery Note form loading
2 participants