Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use 'boolean' parameter while fetching FY year #38082

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 14, 2023

fixes: #38050

fy_exception.mp4

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #38082 (c31ee8e) into develop (d380bf8) will increase coverage by 0.00%.
Report is 10 commits behind head on develop.
The diff coverage is 50.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38082   +/-   ##
========================================
  Coverage    67.38%   67.39%           
========================================
  Files          757      757           
  Lines        60418    60449   +31     
========================================
+ Hits         40712    40737   +25     
- Misses       19706    19712    +6     
Files Coverage Δ
erpnext/accounts/utils.py 73.17% <50.00%> (-0.06%) ⬇️

... and 6 files with indirect coverage changes

@ruthra-kumar ruthra-kumar marked this pull request as ready for review November 14, 2023 03:02
@ruthra-kumar ruthra-kumar merged commit 3e884d3 into frappe:develop Nov 16, 2023
ruthra-kumar added a commit that referenced this pull request Nov 16, 2023
…-38082

refactor: use 'boolean' parameter while fetching FY year (backport #38082)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid FY message on setup wizard
1 participant