-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: set exchange rate on foreign currency JE from Bank Reconciliation #37625
Merged
ruthra-kumar
merged 2 commits into
frappe:develop
from
ruthra-kumar:set_multi_currency_fields_for_je_in_bank_reconciliation
Oct 25, 2023
Merged
refactor: set exchange rate on foreign currency JE from Bank Reconciliation #37625
ruthra-kumar
merged 2 commits into
frappe:develop
from
ruthra-kumar:set_multi_currency_fields_for_je_in_bank_reconciliation
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad367b9
to
89f4842
Compare
Codecov Report
@@ Coverage Diff @@
## develop #37625 +/- ##
===========================================
- Coverage 67.34% 67.32% -0.02%
===========================================
Files 757 757
Lines 60098 60144 +46
===========================================
+ Hits 40472 40491 +19
- Misses 19626 19653 +27
|
ruthra-kumar
added a commit
that referenced
this pull request
Oct 25, 2023
…-37625 refactor: set exchange rate on foreign currency JE from Bank Reconciliation (backport #37625)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 15, 2023
…-37625 refactor: set exchange rate on foreign currency JE from Bank Reconciliation (backport #37625)
@mergify backport version-15 |
✅ Backports have been created
|
ruthra-kumar
added a commit
that referenced
this pull request
Dec 15, 2023
refactor: set exchange rate on foreign currency JE from Bank Reconciliation (backport #37625)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
needs-tests
This PR needs automated unit-tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making foreign currency Journal Entries from Bank Reconciliation, set exchange rate and, Debit and Credit values based on that exchange rate.