Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider 0 if rate/qty are null (backport #35338) #35340

Merged
merged 1 commit into from
May 17, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 17, 2023

This is an automatic backport of pull request #35338 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[skip ci]

(cherry picked from commit e5c86bc)
@mergify mergify bot requested a review from deepeshgarg007 as a code owner May 17, 2023 10:35
@mergify mergify bot assigned ankush May 17, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 17, 2023
@ankush ankush merged commit 15c1af3 into version-14-hotfix May 17, 2023
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-35338 branch May 17, 2023 10:47
frappe-pr-bot pushed a commit that referenced this pull request May 24, 2023
# [14.25.0](v14.24.3...v14.25.0) (2023-05-24)

### Bug Fixes

* consider 0 if rate/qty are null (backport [#35338](#35338)) ([#35340](#35340)) ([15c1af3](15c1af3))
* Creating landed cost voucher from connections ([2631224](2631224))
* depreciation schedule for existing assets [v14] ([#35255](#35255)) ([0a080ef](0a080ef))
* don't recalculate rate for SCR rejected warehouse SLE ([633a170](633a170))
* error while saving job card ([fb7d3b7](fb7d3b7))
* incorrect depr schedule and posting dates on selling of existing assets [v14] ([#35396](#35396)) ([8af6a11](8af6a11))
* Pick List Status ([4888436](4888436))
* Pick List TypeError ([6df9b53](6df9b53))
* possible type error on quotation -> sales order creation ([d23b93a](d23b93a))
* replace quotation with invoice in first onboarding (backport [#35389](#35389)) ([#35394](#35394)) ([9b9772e](9b9772e))
* tds incorrectly calculated for invoice that are below threshold ([bdf81a4](bdf81a4))
* **test:** cumulative threshold checks ([879946e](879946e))
* use flt instead of mandatory field ([668b092](668b092))
* **ux:** SCR consumed-qty read-only property ([aa7fede](aa7fede))

### Features

* provision to make reposting entries from Stock and Account Value Comparison Report ([3a0cdf3](3a0cdf3))
* provision to skip available sub assembly items in the production plan ([ce601af](ce601af))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants