Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Concurrency issues in Sales and Purchase returns" #34202

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Revert "fix: Concurrency issues in Sales and Purchase returns" #34202

merged 1 commit into from
Feb 24, 2023

Conversation

deepeshgarg007
Copy link
Member

Reverts #34019

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 24, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Feb 24, 2023
@deepeshgarg007 deepeshgarg007 merged commit e26c6dc into develop Feb 24, 2023
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
@deepeshgarg007 @mergify
Revert "fix: Concurrency issues in Sales and Purchase returns" (#34202)
9341d3e 
Revert "fix: Concurrency issues in Sales and Purchase returns (#34019)"

This reverts commit a67284e.

(cherry picked from commit e26c6dc)
@mergify mergify bot mentioned this pull request Feb 24, 2023
Merged
deepeshgarg007 added a commit that referenced this pull request Feb 24, 2023
@deepeshgarg007
Merge pull request #34203 from frappe/mergify/bp/version-14-hotfix/pr…
c6a46bc 
…-34202

Revert "fix: Concurrency issues in Sales and Purchase returns" (backport #34202)
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
@deepeshgarg007 @mergify
Revert "fix: Concurrency issues in Sales and Purchase returns" (#34202)
3c2e21e 
Revert "fix: Concurrency issues in Sales and Purchase returns (#34019)"

This reverts commit a67284e.

(cherry picked from commit e26c6dc)
(cherry picked from commit 9341d3e)
deepeshgarg007 added a commit that referenced this pull request Feb 24, 2023
@deepeshgarg007
Merge pull request #34204 from frappe/mergify/bp/version-14/pr-34203
d6d1238 
Revert "fix: Concurrency issues in Sales and Purchase returns" (backport #34202) (backport #34203)
frappe-pr-bot pushed a commit that referenced this pull request Feb 24, 2023
@frappe-bot
chore(release): Bumped to Version 14.17.1
cb266cd 
## [14.17.1](v14.17.0...v14.17.1) (2023-02-24)

### Reverts

* Revert "fix: Concurrency issues in Sales and Purchase returns" (#34202) ([3c2e21e](3c2e21e)), closes [#34202](#34202) [#34019](#34019)
@ankush ankush deleted the revert-34019-sales_return_concurrency branch February 24, 2023 10:09
frappe-pr-bot pushed a commit that referenced this pull request Feb 28, 2023
@frappe-bot
chore(release): Bumped to Version 14.17.2
cc4448b 
## [14.17.2](v14.17.1...v14.17.2) (2023-02-28)

### Bug Fixes

* conversion factor not set ([089c7d0](089c7d0))
* currency in coa import ([#34174](#34174)) ([4d92d46](4d92d46))
* default date in Subcontracting reports ([5fce8e2](5fce8e2))
* german translations ([#31732](#31732)) ([88a781f](88a781f))
* incorrect acc depr amount if multiple FBs with straight line or manual method ([dda6bae](dda6bae))
* incorrect color in the BOM Stock Report ([001ed9e](001ed9e))
* manual depr schedule ([971c072](971c072))
* multiple pos conversion issue resolved ([db964e8](db964e8))
* not able to repost gl entries ([ae0318e](ae0318e))
* permission error while calling get_work_order_items ([3ea90ee](3ea90ee))
* pos return throwing amount greater than grand total ([9cd7b27](9cd7b27))
* Remove missing DocField in fetch_from ([dc6ae46](dc6ae46))
* set `from_warehouse` and `to_warehouse` while mapping SE ([80e23d0](80e23d0))
* **test:** use standalone method to fetch work orders from SO ([1719884](1719884))
* ui freeze on item selection in sales invoice ([1750ed4](1750ed4))
* user shouldn't able to make item price for item template ([fb8e45d](fb8e45d))
* zero division error while making LCV ([1859be6](1859be6))

### Performance Improvements

* fetch SLE's on demand and memoize ([db1f17e](db1f17e))

### Reverts

* Revert "fix: Concurrency issues in Sales and Purchase returns" (#34202) ([9341d3e](9341d3e)), closes [#34202](#34202) [#34019](#34019)
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepeshgarg007