Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update set query for warehouse after changing the company #22632

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

AfshanKhan
Copy link
Contributor

Previously after changing the company in material request form the options for warehouses were still showing warehouses of the company selected at first.
Screenshot 2020-07-09 at 6 36 08 PM
Screenshot 2020-07-09 at 6 36 22 PM

So made changes to update set query after changing the company
Screenshot 2020-07-09 at 6 42 21 PM
Screenshot 2020-07-09 at 6 42 33 PM

@rohitwaghchaure
Copy link
Collaborator

@AfshanKhan the old code is working correctly in v12 (check GIF), it seems that the setup function is not using the current doc. You need to fix that.

@AfshanKhan
Copy link
Contributor Author

AfshanKhan commented Jul 10, 2020

@rohitwaghchaure Updated the code. Removed previous changes and replaced set_query with get_query.

@AfshanKhan AfshanKhan reopened this Jul 10, 2020
@marination marination self-assigned this Jul 10, 2020
…tion-for-mr

Merge remote-tracking branch 'upstream/develop' into fix-warehouse-option-for-mr
…tion-for-mr

Merge remote-tracking branch 'upstream/develop' into fix-warehouse-option-for-mr
@marination
Copy link
Collaborator

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2020

Command backport version-12-hotfix: pending

Waiting for the pull request to get merged

@marination marination merged commit 66d4b42 into frappe:develop Jul 21, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed
    backport fail: repository is too big and no subscription is active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants