Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for Company before trying to fetch party details #22576

Merged
merged 2 commits into from
Jul 6, 2020
Merged

fix: Check for Company before trying to fetch party details #22576

merged 2 commits into from
Jul 6, 2020

Conversation

marination
Copy link
Collaborator

Issue:

  • On a document without company (Sales or Purchase)
    _error

Fix:

  • Company check in get_party_details
    Screenshot 2020-07-03 at 10 08 15 PM
  • Use frappe.throw instead of msgprint
  • Style consistency fixes

@rohitwaghchaure rohitwaghchaure self-assigned this Jul 4, 2020
@rohitwaghchaure rohitwaghchaure merged commit 1cc1fd4 into frappe:develop Jul 6, 2020
@marination
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2020

Command backport version-12-hotfix: failure

No backport have been created

  • Backport to branch version-12-hotfix failed
    backport fail: repository is too big and no subscription is active

@frappe frappe deleted a comment from mergify bot Aug 29, 2020
@marination marination mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitwaghchaure rohitwaghchaure rohitwaghchaure approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees

@rohitwaghchaure rohitwaghchaure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marination @rohitwaghchaure