refactor: raise exception on invalid date

(cherry picked from commit a393a6b)
frappe · Nov 17, 2023 · fa1f623 · fa1f623
1 parent 8dbe753
commit fa1f623
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.js b/erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.js
@@ -14,7 +14,7 @@ frappe.ui.form.on("Bulk Transaction Log", {
 				frappe.call({
 					method: "erpnext.utilities.bulk_transaction.retry",
 					args: {date: frm.doc.date}
-				}).then(()=> {	});
+				});
 			});
 		}
 	},

diff --git a/erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.py b/erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.py
@@ -15,6 +15,13 @@ def db_insert(self, *args, **kwargs):
 
 	def load_from_db(self):
 		log_detail = qb.DocType("Bulk Transaction Log Detail")
+
+		has_records = frappe.db.sql(
+			f"select exists (select * from `tabBulk Transaction Log Detail` where date = '{self.name}');"
+		)[0][0]
+		if not has_records:
+			raise frappe.DoesNotExistError
+
 		succeeded_logs = (
 			qb.from_(log_detail)
 			.select(Count(log_detail.date).as_("count"))