Skip to content

Commit

Permalink
Merge pull request #23989 from Anurag810/item-maintain-stock-fixes
Browse files Browse the repository at this point in the history
fix: maintain stock can't be changed it there is product bundle
  • Loading branch information
rohitwaghchaure authored Nov 24, 2020
2 parents d39ebf2 + 927106f commit ccd554c
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions erpnext/stock/doctype/item/item.py
Original file line number Diff line number Diff line change
Expand Up @@ -977,15 +977,20 @@ def check_if_linked_document_exists(self, field):
# For "Is Stock Item", following doctypes is important
# because reserved_qty, ordered_qty and requested_qty updated from these doctypes
if field == "is_stock_item":
linked_doctypes += ["Sales Order Item", "Purchase Order Item", "Material Request Item"]
linked_doctypes += ["Sales Order Item", "Purchase Order Item", "Material Request Item", "Product Bundle"]

for doctype in linked_doctypes:
filters={"item_code": self.name, "docstatus": 1}

if doctype == "Product Bundle":
filters={"new_item_code": self.name}

if doctype in ("Purchase Invoice Item", "Sales Invoice Item",):
# If Invoice has Stock impact, only then consider it.
if self.stock_ledger_created():
return True

elif frappe.db.get_value(doctype, filters={"item_code": self.name, "docstatus": 1}):
elif frappe.db.get_value(doctype, filters):
return True

def validate_auto_reorder_enabled_in_stock_settings(self):
Expand Down

0 comments on commit ccd554c

Please sign in to comment.