fix: valuation rate for batch

frappe · Feb 23, 2025 · b88305a · b88305a
1 parent a81867b
commit b88305a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/erpnext/stock/deprecated_serial_batch.py b/erpnext/stock/deprecated_serial_batch.py
@@ -365,6 +365,8 @@ def get_last_sle_for_sabb_no_batchwise_valuation(self):
 		if self.sle.voucher_detail_no:
 			query = query.where(sabb.voucher_detail_no != self.sle.voucher_detail_no)
 
+		query = query.where(sabb.voucher_type != "Pick List")
+
 		data = query.run(as_dict=True)
 		if not data:
 			return {}

diff --git a/erpnext/stock/doctype/bin/bin.py b/erpnext/stock/doctype/bin/bin.py
@@ -247,7 +247,7 @@ def update_qty(bin_name, args):
 				& (sle.warehouse == args.get("warehouse"))
 				& (sle.is_cancelled == 0)
 			)
-			.orderby(CombineDatetime(sle.posting_date, sle.posting_time), order=Order.desc)
+			.orderby(sle.posting_datetime, order=Order.desc)
 			.orderby(sle.creation, order=Order.desc)
 			.limit(1)
 			.run()