You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I know we discussed this isn't used, but why remove it? If the framework changes in the future to cache this type of filtered lookup, this will be missed.
6a47a2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we discussed this isn't used, but why remove it? If the framework changes in the future to cache this type of filtered lookup, this will be missed.
6a47a2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it to fix formatting at first but then felt it was redundant anyway so removed it.
It's unlikely to efficiently implement cache keys for filters.
Also, full bootinfo gets cached (?)