fix: move condition for shipment

frappe · Jun 20, 2024 · 2180239 · 2180239
1 parent 9bad219
commit 2180239
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.js b/erpnext/stock/doctype/delivery_note/delivery_note.js
@@ -188,8 +188,8 @@ erpnext.stock.DeliveryNoteController = class DeliveryNoteController extends (
 			);
 		}
 
-		if (!doc.is_return && doc.status != "Closed" && frappe.model.can_create("Shipment")) {
-			if (doc.docstatus == 1) {
+		if (!doc.is_return && doc.status != "Closed") {
+			if (doc.docstatus == 1 && frappe.model.can_create("Shipment")) {
 				this.frm.add_custom_button(
 					__("Shipment"),
 					function () {