fix: minor changes

frappe · May 13, 2020 · 0d19e4a · 0d19e4a
1 parent 24e6bc5
commit 0d19e4a
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/erpnext/setup/setup_wizard/operations/install_fixtures.py b/erpnext/setup/setup_wizard/operations/install_fixtures.py
@@ -329,17 +329,14 @@ def add_uom_data():
 
 	# bootstrap uom conversion factors
 	uom_conversions = json.loads(open(frappe.get_app_path("erpnext", "setup", "setup_wizard", "data", "uom_conversion_data.json")).read())
-	uom_conversion_factor = frappe.db.get_all("UOM Conversion Factor", fields=["*"])
 	for d in uom_conversions:
 		if not frappe.db.exists("UOM Category", _(d.get("category"))):
 			frappe.get_doc({
 				"doctype": "UOM Category",
 				"category_name": _(d.get("category"))
 			}).insert(ignore_permissions=True)
 
-		existing_uom_conversion_factor = next((data for data in uom_conversion_factor if (data.get("from_uom") == _(d.get("from_uom"))) and\
-			(data.get("to_uom") == _(d.get("to_uom")))), None)
-		if not existing_uom_conversion_factor:
+		if not frappe.db.exists("UOM Conversion Factor", {"from_uom": _(d.get("from_uom")), "to_uom": _(d.get("to_uom"))}):
 			uom_conversion = frappe.get_doc({
 				"doctype": "UOM Conversion Factor",
 				"category": _(d.get("category")),