Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Translations - Part 2 Use Translations #341

Merged
merged 11 commits into from
Feb 17, 2022

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Feb 16, 2022

Todo

  • Check builds
  • Update Setup Wizard to fetch and set translation file.
  • Add a Contribution Notes
  • Add check for translation updates.
  • Update translation.js to generate and make use of translation map.
  • Add a some translation files
  • Add script to generate translation file .csv.
  • Convert all translation instances to translation template strings.

this will close #149

@18alantom 18alantom marked this pull request as draft February 16, 2022 08:18
@18alantom 18alantom marked this pull request as ready for review February 17, 2022 10:35
@18alantom
Copy link
Member Author

There's a strange issue where reloading the window on language change causes the Production version to hang around 40% of the time.

I think this is cause of the mainProcess fetch, which should be occurring before the reload.

Nevertheless will try and fix this issue later, translations are working properly, only strings need to be added.

@18alantom 18alantom merged commit 03c7b76 into frappe:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language issues
1 participant