Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Translations - Part 1 #334

Merged
merged 10 commits into from
Feb 16, 2022
Merged

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Feb 9, 2022

Todo

  • Add check for translation updates.
  • Update translation.js to generate and make use of translation map.
  • Update setup to fetch and set translation file.
  • Add a CONTRIBUTIONS.md somewhere
  • Add a some translation files
  • Add script to generate translation file .csv.
  • Convert all translation instances to translation template strings.

Will add more details soon.

As of now converting all non-idiomatic occurrences of t, eg: t('value: {}', 0) to idiomatic ones i.e:

t`value ${0}`

I've reached a bit of an impasse as it seems Vue 2.x doesn't support this syntax in SFC templates 😐
Impasse, passed, Vue is now at 3 😎

As for why am I doing this? Basically reducing the amount of regex I have to write, more regex == more misery.

@18alantom 18alantom marked this pull request as draft February 9, 2022 07:31
@18alantom 18alantom mentioned this pull request Feb 11, 2022
@18alantom 18alantom changed the title Setup translations Setup Translations - Part 1 Feb 16, 2022
@18alantom 18alantom marked this pull request as ready for review February 16, 2022 07:43
@18alantom
Copy link
Member Author

This PR basically sets the stage for translations to take place, the next one will enable it.
Due to how it will be handled I need to push it through two separate PRs.

@18alantom 18alantom merged commit 6cfab5c into frappe:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants